Differential D21653

Formally track "initial", "committed", and "active" states for inline comments
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 9:10 PM.

Tags

None

Referenced Files

	F14496536: D21653.id51522.diff
	Fri, Jan 3, 2:21 PM

	Unknown Object (File)
	Sun, Dec 22, 6:13 PM

	Unknown Object (File)
	Sun, Dec 22, 1:16 AM

	Unknown Object (File)
	Fri, Dec 20, 10:39 PM

	Unknown Object (File)
	Mon, Dec 9, 1:02 AM

	Unknown Object (File)
	Thu, Dec 5, 2:12 AM

	Unknown Object (File)
	Nov 30 2024, 7:13 PM

	Unknown Object (File)
	Nov 27 2024, 10:43 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits: rP6fd55d692f14: Formally track "initial", "committed", and "active" states for inline comments

Summary

Ref T13559. Various client decisions depend on the "initial" or "committed" states of inline comments. Previously, these were informally constructed from "mostly similar" available values, or glossed over in some cases.

On the server, save the initial state when creating a comment. Save the committed state when applying a "save" operation. Send all three states to the client.

On the client, load and track all three states explicitly.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository

Branch

istate10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25330
Build 34975: Run Core Tests
Build 34974: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 25 2021, 9:10 PM

Harbormaster completed remote builds in B25330: Diff 51522.Mar 25 2021, 9:11 PM

epriestley requested review of this revision.Mar 25 2021, 9:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:01 PM

Closed by commit rP6fd55d692f14: Formally track "initial", "committed", and "active" states for inline comments (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6fd55d692f14: Formally track "initial", "committed", and "active" states for inline comments.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

infrastructure/

diff/

PhabricatorInlineCommentController.php

93 lines

interface/

PhabricatorInlineComment.php

88 lines

view/

PHUIDiffInlineCommentView.php

2 lines

webroot/

rsrc/

js/

application/

diff/

32 lines

Diff 51522

resources/celerity/map.php

Loading...

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...

src/infrastructure/diff/interface/PhabricatorInlineComment.php

Loading...

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...

webroot/rsrc/js/application/diff/DiffInline.js

Loading...