Page MenuHomePhabricator

Formally track "initial", "committed", and "active" states for inline comments
ClosedPublic

Authored by epriestley on Mar 25 2021, 9:10 PM.
Tags
None
Referenced Files
F15452376: D21653.diff
Sat, Mar 29, 4:17 AM
F15444913: D21653.id51546.diff
Thu, Mar 27, 11:52 AM
F15443326: D21653.id51522.diff
Thu, Mar 27, 3:44 AM
F15435905: D21653.id.diff
Tue, Mar 25, 10:50 AM
F15430649: D21653.id51546.diff
Mon, Mar 24, 8:30 AM
F15430542: D21653.diff
Mon, Mar 24, 8:04 AM
F15379254: D21653.id51546.diff
Thu, Mar 13, 7:46 PM
F15333678: D21653.diff
Sat, Mar 8, 3:59 AM
Subscribers
None

Details

Summary

Ref T13559. Various client decisions depend on the "initial" or "committed" states of inline comments. Previously, these were informally constructed from "mostly similar" available values, or glossed over in some cases.

On the server, save the initial state when creating a comment. Save the committed state when applying a "save" operation. Send all three states to the client.

On the client, load and track all three states explicitly.

Test Plan

Created inlines, etc. See followups.

Diff Detail

Repository
rP Phabricator
Branch
istate10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25330
Build 34975: Run Core Tests
Build 34974: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:01 PM
This revision was automatically updated to reflect the committed changes.