Differential D21643

On Windows, implement "Filesystem::copyFile()" with "copy()"
ClosedPublic
Actions

Authored by epriestley on Mar 22 2021, 6:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 22, 11:24 AM

	Unknown Object (File)
	Sun, Jan 19, 5:53 PM

	Unknown Object (File)
	Fri, Jan 17, 9:54 PM

	Unknown Object (File)
	Fri, Dec 27, 6:00 PM

	Unknown Object (File)
	Fri, Dec 27, 5:03 PM

	Unknown Object (File)
	Dec 21 2024, 5:28 PM

	Unknown Object (File)
	Dec 16 2024, 1:37 PM

	Unknown Object (File)
	Dec 14 2024, 4:54 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions
Commits: rARC7af9846f994a: (stable) Promote 2021 Week 13
rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()"

Summary

Ref T13562. Currently, "Filesystem::copyFile()" uses "copy", which doesn't work now that we no longer invoke "cmd.exe" by default.

Use "copy()" instead.

Note that this whole function is probably nonsense, but I'll follow up on T13562.

Test Plan

Created a standalone script which runs "Filesystem::copyFile()".
- Before: failed to copy any file.
- After: succesfully copied normal files.
- After: failed to copy a file over an existing directory with a reasonable error.
- After: failed to copy a file over itself with a reasonable error.

Diff Detail

Repository

Branch

win1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25317
Build 34951: Run Core Tests
Build 34950: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 22 2021, 6:43 PM

Harbormaster completed remote builds in B25317: Diff 51509.Mar 22 2021, 6:43 PM

epriestley requested review of this revision.Mar 22 2021, 6:43 PM

epriestley mentioned this in T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.Mar 22 2021, 6:59 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2021, 7:00 PM

Closed by commit rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()".

epriestley added a commit: rARC7af9846f994a: (stable) Promote 2021 Week 13.Mar 26 2021, 6:05 PM

Revision Contents
Changeset List

Path

Size

src/

filesystem/

24 lines

Diff 51509

src/filesystem/Filesystem.php

Loading...