When using "Update Diff" from the web UI, prefill "Repository" properly
ClosedPublic
Actions

Authored by epriestley on Mar 17 2021, 7:19 PM.

Details

Reviewers: None
Maniphest Tasks: T9499: Revision repository is not updated when it is changed in the UI
Commits: rP1d1003af7854: When using "Update Diff" from the web UI, prefill "Repository" properly

Summary

Ref T9499. When using the manual "Update Diff" workflow on the web, the "Repository" field isn't pre-filled properly. This can lead to revisions losing their repository after a manual update.

Test Plan

Did a manual update of a revision with a repository, saw it stick.

Diff Detail

Repository

rP Phabricator

Branch

diff1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25307
Build 34935: Run Core Tests
Build 34934: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 17 2021, 7:19 PM

Harbormaster completed remote builds in B25307: Diff 51499.Mar 17 2021, 7:20 PM

epriestley requested review of this revision.Mar 17 2021, 7:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 7:23 PM

Closed by commit rP1d1003af7854: When using "Update Diff" from the web UI, prefill "Repository" properly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP1d1003af7854: When using "Update Diff" from the web UI, prefill "Repository" properly.

epriestley mentioned this in T9499: Revision repository is not updated when it is changed in the UI.Mar 17 2021, 7:23 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialDiffCreateController.php

8 lines

Diff 51499

View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

When using "Update Diff" from the web UI, prefill "Repository" properlyClosedPublicActions