Forbid disabled devices from authenticating via SSH or HTTP
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 10:41 PM.

Details

Reviewers: None
Maniphest Tasks: T13641: Support "Disabled" devices in Almanac
Commits: rP12341e4bc8b4: Forbid disabled devices from authenticating via SSH or HTTP

Summary

Ref T13641. Phabricator sometimes makes intracluster requests that authenticate as a device.

Forbid these requests from authenticating as a disabled device.

Test Plan

Ran bin/ssh-exec --phabricator-ssh-device ... as an enabled/disabled device (worked; sensible error).
Made Conduit calls as an enable/disabled device (worked; sensible error).

Diff Detail

Repository

rP Phabricator

Branch

almanac11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25291
Build 34916: Run Core Tests
Build 34915: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 10:41 PM

Harbormaster completed remote builds in B25291: Diff 51483.Mar 16 2021, 10:42 PM

epriestley requested review of this revision.Mar 16 2021, 10:42 PM

epriestley mentioned this in T13641: Support "Disabled" devices in Almanac.Mar 16 2021, 10:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:52 PM

Closed by commit rP12341e4bc8b4: Forbid disabled devices from authenticating via SSH or HTTP (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP12341e4bc8b4: Forbid disabled devices from authenticating via SSH or HTTP.

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

ssh-exec.php

8 lines

src/

applications/

conduit/

controller/

PhabricatorConduitAPIController.php

10 lines

Diff 51483

View Options

scripts/ssh/ssh-exec.php