Page MenuHomePhabricator
Differential D21630

Modernize "mailKey" for Almanac Bindings
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 10:52 AM
Unknown Object (File)
Sat, Dec 28, 1:23 PM
Unknown Object (File)
Sun, Dec 22, 11:55 AM
Unknown Object (File)
Tue, Dec 10, 1:51 PM
Unknown Object (File)
Dec 3 2024, 9:59 PM
Unknown Object (File)
Dec 3 2024, 9:59 PM
Unknown Object (File)
Dec 3 2024, 9:58 PM
Unknown Object (File)
Dec 3 2024, 9:40 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13065: Move storage for `mailKey` to the Mail application
T13641: Support "Disabled" devices in Almanac
Commits
rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings
Summary

Ref T13065. Ref T13641. Migrate "mailKey" and drop the column.

Test Plan

Ran "bin/storage upgrade", got a clean report and saw binding mail keys in the mail properties table.

Diff Detail

Repository
rP Phabricator
Branch
almanac6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25286
Build 34906: Run Core Tests
Build 34905: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 10:05 PM
Owners added a subscriber: Restricted Owners Package.Mar 16 2021, 10:05 PM
Harbormaster completed remote builds in B25286: Diff 51478.Mar 16 2021, 10:06 PM
epriestley requested review of this revision.Mar 16 2021, 10:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:52 PM
Closed by commit rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7c0e33c34d6f: Modernize "mailKey" for Almanac Bindings.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
28 lines
2 lines
src/
applications/
almanac/
storage/
17 lines

Diff 51478

View Options

resources/sql/autopatches/20210316.almanac.07.binding-mailkey.php

Loading...
View Options

resources/sql/autopatches/20210316.almanac.08.binding-dropmailkey.sql

Loading...
View Options

src/applications/almanac/storage/AlmanacBinding.php

Loading...
Phabricator · Built by Phacility