Give audit statuses API constants that match their UI strings
ClosedPublic
Actions

Authored by epriestley on Mar 10 2021, 6:07 PM.

Details

Reviewers: None
Maniphest Tasks: T13631: Support an "auditors" attachment for "diffusion.commit.search"
Commits: rP404b55ce573a: Give audit statuses API constants that match their UI strings

Summary

Ref T13631. These strings were a little inconsistent; make them more consistent.

Test Plan

Called diffusion.commit.search with the appropriate attachment, saw slightly more consistent statuses.

Diff Detail

Repository

rP Phabricator

Branch

audit4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25230
Build 34820: Run Core Tests
Build 34819: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 10 2021, 6:07 PM

Harbormaster completed remote builds in B25230: Diff 51423.Mar 10 2021, 6:08 PM

epriestley requested review of this revision.Mar 10 2021, 6:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 6:20 PM

Closed by commit rP404b55ce573a: Give audit statuses API constants that match their UI strings (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP404b55ce573a: Give audit statuses API constants that match their UI strings.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditRequestStatus.php

11 lines

diffusion/

engineextension/

DiffusionAuditorsSearchEngineAttachment.php

2 lines

Diff 51423

View Options

src/applications/audit/constants/PhabricatorAuditRequestStatus.php