Page MenuHomePhabricator
Differential D21598

Remove very old Audit status constants and AuditRequest data
ClosedPublic
Actions

Authored by epriestley on Mar 10 2021, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:28 AM
Unknown Object (File)
Fri, Dec 13, 1:25 AM
Unknown Object (File)
Mon, Dec 9, 12:24 PM
Unknown Object (File)
Sat, Dec 7, 6:55 AM
Unknown Object (File)
Fri, Dec 6, 7:40 PM
Unknown Object (File)
Fri, Dec 6, 1:13 PM
Unknown Object (File)
Thu, Dec 5, 2:46 AM
Unknown Object (File)
Sun, Dec 1, 12:43 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13631: Support an "auditors" attachment for "diffusion.commit.search"
Commits
rP2636d84d0c24: Remove very old Audit status constants and AuditRequest data
Summary

Ref T13631. See that task for discussion.

  • "NONE": Probably never used?
  • "CC": Obsoleted by subscribers.
  • "AUDIT_NOT_REQUIRED": For Owners packages, obsoleted by edges.
  • "CLOSED": For "Close Audit", obsoleted by "Request Verification".
Test Plan
  • Grepped for constants, browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
auditors2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25225
Build 34813: Run Core Tests
Build 34812: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 10 2021, 12:01 AM
Owners added a subscriber: Restricted Owners Package.Mar 10 2021, 12:01 AM
Harbormaster completed remote builds in B25225: Diff 51418.Mar 10 2021, 12:02 AM
epriestley requested review of this revision.Mar 10 2021, 12:02 AM
epriestley added inline comments.Mar 10 2021, 12:08 AM
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
52

After these changes, this just means "is not-resigned", and we already have "isResigned()" to test for that.

65–73

After these changes, all audit requests are "interesting".

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
Closed by commit rP2636d84d0c24: Remove very old Audit status constants and AuditRequest data (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2636d84d0c24: Remove very old Audit status constants and AuditRequest data.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
5 lines
src/
applications/
audit/
constants/
18 lines
editor/
7 lines
diffusion/
controller/
4 lines
herald/
4 lines
6 lines
repository/
storage/
23 lines

Diff 51418

View Options

resources/sql/autopatches/20210309.auditors.01.status.sql

Loading...
View Options

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionAuditorsHeraldAction.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAuditorsHeraldField.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php

Loading...
Phabricator · Built by Phacility