Use the same icon for "Resigned" in Differential and Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 4 2021, 5:24 PM.

Details

Reviewers: None
Commits: rP9b6a030292d1: Use the same icon for "Resigned" in Differential and Diffusion

Summary

See PHI2015. Currently, "resigned" reviewers/auditors get different icons in Differential and Diffusion.

The Diffusion icon is exceptionally poor and confusing: it does not communicate "resigned" and it is similar to other icons.

For clarity and consistency, use the Differential icon (a grey "X") in both applications.

Test Plan

Screen Shot 2021-03-04 at 9.21.32 AM.png (88×191 px, 8 KB)

Diff Detail

Repository

rP Phabricator

Branch

icon1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25214
Build 34797: Run Core Tests
Build 34796: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 4 2021, 5:24 PM

This icon originally dates from D6562.

Differential didn't have an icon until D17531, since "resigned" wasn't a distinct state until then.

Harbormaster completed remote builds in B25214: Diff 51409.Mar 4 2021, 5:25 PM

epriestley requested review of this revision.Mar 4 2021, 5:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 5:33 PM

Closed by commit rP9b6a030292d1: Use the same icon for "Resigned" in Differential and Diffusion (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9b6a030292d1: Use the same icon for "Resigned" in Differential and Diffusion.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditStatusConstants.php

8 lines

Diff 51409

View Options

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

Use the same icon for "Resigned" in Differential and DiffusionClosedPublicActions