Differential D21588

In Arcanist, when trying to write to a file configuration source, create missing directories
ClosedPublic
Actions

Authored by epriestley on Mar 3 2021, 9:06 PM.

Tags

None

Referenced Files

	F14792266: D21588.id.diff
	Fri, Jan 24, 11:07 PM

	Unknown Object (File)
	Sun, Jan 19, 5:54 PM

	Unknown Object (File)
	Fri, Jan 17, 6:57 PM

	Unknown Object (File)
	Fri, Jan 10, 10:35 PM

	Unknown Object (File)
	Fri, Jan 10, 10:04 PM

	Unknown Object (File)
	Fri, Jan 10, 7:17 PM

	Unknown Object (File)
	Thu, Jan 2, 4:43 AM

	Unknown Object (File)
	Dec 17 2024, 7:34 AM

Subscribers

None

Details

Reviewers: None
Commits: rARC2d6452acb5f1: In Arcanist, when trying to write to a file configuration source, create…

Summary

The ".git/arc" directory may need to be created when writing to working copy configuration.

Test Plan

Tried to store an answer to a prompt in a new working copy.
Before: error that ".git/arc" does not exist.
After: prompt saved to working copy configuration.

Diff Detail

Repository

Branch

local1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25204
Build 34782: Run Core Tests
Build 34781: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 3 2021, 9:06 PM

Harbormaster completed remote builds in B25204: Diff 51399.Mar 3 2021, 9:06 PM

epriestley requested review of this revision.Mar 3 2021, 9:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2021, 9:41 PM

Closed by commit rARC2d6452acb5f1: In Arcanist, when trying to write to a file configuration source, create… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC2d6452acb5f1: In Arcanist, when trying to write to a file configuration source, create….

Revision Contents
Changeset List

Path

Size

src/

config/

source/

ArcanistFilesystemConfigurationSource.php

15 lines

Diff 51399

src/config/source/ArcanistFilesystemConfigurationSource.php

Loading...