Paths

Table of Contentst

When a GlobalLock with an external connection is released, don't return it to the pool
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 8:49 PM.

Details

Reviewers: None
Maniphest Tasks: T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits: rPaa2d89f1d4c5: (stable) When a GlobalLock with an external connection is released, don't…
rP15dbf6bdf0a5: When a GlobalLock with an external connection is released, don't return it to…

Summary

Ref T13627. Currently, global locks always return connections (even external connections) to the connection pool when unlocked.

This code is obviously buggy: isExternalConnection is set to false immediately before it is tested. This bug has existed since this code was introduced, in D15792.

Instead of storing a flag, store the actual connection.
Don't clear it when unlocking.
Don't return external connections to the pool.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository

rP Phabricator

Branch

lock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25188
Build 34761: Run Core Tests
Build 34760: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2021, 8:49 PM

Harbormaster completed remote builds in B25188: Diff 51380.Mar 2 2021, 8:50 PM

epriestley requested review of this revision.Mar 2 2021, 8:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2021, 9:44 PM

Closed by commit rP15dbf6bdf0a5: When a GlobalLock with an external connection is released, don't return it to… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP15dbf6bdf0a5: When a GlobalLock with an external connection is released, don't return it to….

epriestley added a commit: rPaa2d89f1d4c5: (stable) When a GlobalLock with an external connection is released, don't….Mar 3 2021, 3:26 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

infrastructure/

util/

PhabricatorGlobalLock.php

17 lines

__tests__/

PhabricatorGlobalLockTestCase.php

92 lines

Diff 51380

View Options

src/__phutil_library_map__.php

View Options

src/infrastructure/util/PhabricatorGlobalLock.php

View Options

src/infrastructure/util/tests/PhabricatorGlobalLockTestCase.php

When a GlobalLock with an external connection is released, don't return it to the poolClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51380

src/__phutil_library_map__.php

src/infrastructure/util/PhabricatorGlobalLock.php

src/infrastructure/util/__tests__/PhabricatorGlobalLockTestCase.php

When a GlobalLock with an external connection is released, don't return it to the pool
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/util/tests/PhabricatorGlobalLockTestCase.php