Apply "pcre.*_limit" config options at startup in CLI environments
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:17 PM.

Details

Reviewers: None
Maniphest Tasks: T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values
T13586: In Herald transcripts, surface exceptions encountered while evaluating fields
Commits: rARCe95afd1d005c: Apply "pcre.*_limit" config options at startup in CLI environments

Summary

Ref T13100. Ref T13586. These options have been in production for a while and seem to consistently improve behavior, downgrading segfaults to runtime errors.

Make them global options for all CLI environments. See next change for web enviornments.

Test Plan

Ran arc.

Diff Detail

Repository

rARC Arcanist

Branch

regex2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25146
Build 34705: Run Core Tests
Build 34704: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2021, 7:17 PM

Harbormaster completed remote builds in B25146: Diff 51337.Feb 18 2021, 7:18 PM

epriestley requested review of this revision.Feb 18 2021, 7:18 PM

epriestley mentioned this in D21567: Apply "pcre.*_limit" ini options in web environments.Feb 18 2021, 7:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 7:16 PM

Closed by commit rARCe95afd1d005c: Apply "pcre.*_limit" config options at startup in CLI environments (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe95afd1d005c: Apply "pcre.*_limit" config options at startup in CLI environments.

epriestley mentioned this in rP20a54a3006de: Apply "pcre.*_limit" ini options in web environments.

Revision Contents
Changeset List

Path

Size

support/

init/

init-script.php

11 lines

Diff 51337

View Options

support/init/init-script.php

Apply "pcre.*_limit" config options at startup in CLI environmentsClosedPublicActions