Differential D21553

Restructure Hovercards to support more context information
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 7:59 PM.

Tags

None

Referenced Files

	F14090759: D21553.id51304.diff
	Sun, Nov 24, 8:10 PM

	Unknown Object (File)
	Thu, Nov 14, 8:43 AM

	Unknown Object (File)
	Thu, Nov 14, 8:39 AM

	Unknown Object (File)
	Thu, Nov 14, 8:24 AM

	Unknown Object (File)
	Thu, Nov 14, 7:45 AM

	Unknown Object (File)
	Thu, Nov 14, 6:42 AM

	Unknown Object (File)
	Sat, Nov 9, 4:23 PM

	Unknown Object (File)
	Wed, Nov 6, 11:59 AM

View All 88 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rP2aac3156f791: Restructure Hovercards to support more context information

Summary

Ref T13602. Currently, Hovercards are functions only of the object they represent (and the viewer, etc).

Recent changes to how users who can't see an object are rendered motivate making them a function of both the object they represent and the context in which they are being viewed. In particular, this enables a hovecard for a user to explain "This user can't see the thing you're lookign at right now.", so visual "exiled" markers can have a path forward toward discovery.

Test Plan

This change isn't expected to affect any behavior.
Viewed hovercards, moused over/out, resized windows, viewed standalone cards, viewed debug cards, saw no behavioral changes.

Diff Detail

Repository

Branch

policy4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25113
Build 34654: Run Core Tests
Build 34653: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2021, 7:59 PM

Harbormaster completed remote builds in B25113: Diff 51304.Feb 13 2021, 8:01 PM

epriestley requested review of this revision.Feb 13 2021, 8:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM

Closed by commit rP2aac3156f791: Restructure Hovercards to support more context information (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2aac3156f791: Restructure Hovercards to support more context information.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

1 line

src/

aphront/

AphrontRequest.php

37 lines

applications/

search/

controller/

PhabricatorSearchHovercardController.php

40 lines

system/

events/

PhabricatorSystemDebugUIEventListener.php

2 lines

webroot/

rsrc/

js/

core/

169 lines

HovercardList.js

226 lines

behavior-hovercard.js

68 lines

Diff 51304

resources/celerity/map.php

Loading...

resources/celerity/packages.php

Loading...

src/aphront/AphrontRequest.php

Loading...

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...

src/applications/system/events/PhabricatorSystemDebugUIEventListener.php

Loading...

webroot/rsrc/js/core/Hovercard.js

Loading...

webroot/rsrc/js/core/HovercardList.js

Loading...

webroot/rsrc/js/core/behavior-hovercard.js

Loading...