Page MenuHomePhabricator

Prevent interruption by the PHP "set_time_limit()" mechanism while holding the durable write lock
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:09 AM.
Tags
None
Referenced Files
F15418961: D21526.id51237.diff
Fri, Mar 21, 2:44 AM
F15411271: D21526.diff
Wed, Mar 19, 8:57 AM
F15411207: D21526.diff
Wed, Mar 19, 8:54 AM
F15411127: D21526.diff
Wed, Mar 19, 8:51 AM
F15411004: D21526.diff
Wed, Mar 19, 8:46 AM
F15410931: D21526.diff
Wed, Mar 19, 8:43 AM
F15397937: D21526.id51237.diff
Sun, Mar 16, 11:02 PM
F15382478: D21526.diff
Fri, Mar 14, 12:35 PM
Subscribers
None

Details

Summary

Ref T13590. By default, PHP kills execution after web scripts run for 30 seconds. If this occurs in the locked section of a repository write while we're holding the durable write lock, the lock will get stuck.

Use "set_time_limit(0)" to prevent this mechanism from interrupting execution while the durable lock is held.

Test Plan
  • Added "set_time_limit(1)" before the lock and "while (1);" in the critical section of the lock.
  • Pushed, got the lock stuck.
  • Cleared the lock, applied this patch, pushed.
  • Got an infinite hang instead. (Normally, we expect the script to take more than 30 seconds to execute because there is a large push that executes in finite time, not because there's an infinte loop.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable