Allow "differential.createinline" to accept JSON "false" for "isNewFile"
ClosedPublic
Actions

Authored by epriestley on Jan 26 2021, 10:48 PM.

Tags

None

Referenced Files

	F15554453: D21522.id51229.diff
	Mon, Apr 28, 7:10 AM

	F15553926: D21522.id51229.diff
	Mon, Apr 28, 4:33 AM

	F15553621: D21522.id51228.diff
	Mon, Apr 28, 2:51 AM

	F15540316: D21522.id.diff
	Fri, Apr 25, 7:05 AM

	F15535373: D21522.diff
	Thu, Apr 24, 4:50 AM

	F15517923: D21522.id51228.diff
	Sat, Apr 19, 9:34 AM

	F15491214: D21522.id51229.diff
	Sat, Apr 12, 12:19 AM

	F15468100: D21522.diff
	Apr 3 2025, 8:15 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPacd767c7f33d: Allow "differential.createinline" to accept JSON "false" for "isNewFile"

Summary

See https://discourse.phabricator-community.org/t/error-creating-inline-comment-via-conduit-api/4535. See T12678.

This API method currently does not accept a JSON "false", but reasonably should.

Test Plan

Called method with "isNewFile: false".
- Before: type error.
- After: inline comment.

Diff Detail

Repository

rP Phabricator

Branch

inline1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25041
Build 34550: Run Core Tests
Build 34549: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 26 2021, 10:48 PM

Harbormaster completed remote builds in B25041: Diff 51228.Jan 26 2021, 10:49 PM

epriestley requested review of this revision.Jan 26 2021, 10:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2021, 10:56 PM

Closed by commit rPacd767c7f33d: Allow "differential.createinline" to accept JSON "false" for "isNewFile" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPacd767c7f33d: Allow "differential.createinline" to accept JSON "false" for "isNewFile".

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateInlineConduitAPIMethod.php

2 lines

Diff 51228

View Options

src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php

Allow "differential.createinline" to accept JSON "false" for "isNewFile"ClosedPublicActions