Page MenuHomePhabricator

Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag
ClosedPublic

Authored by epriestley on Jan 22 2021, 9:41 PM.
Tags
None
Referenced Files
F13235757: D21514.id51208.diff
Tue, May 21, 6:26 AM
F13210802: D21514.diff
Fri, May 17, 5:13 AM
F13194726: D21514.diff
Sun, May 12, 9:50 PM
F13177491: D21514.diff
Wed, May 8, 7:45 PM
Unknown Object (File)
Thu, May 2, 2:13 AM
Unknown Object (File)
Mon, Apr 29, 3:21 PM
Unknown Object (File)
Sat, Apr 27, 4:01 PM
Unknown Object (File)
Wed, Apr 24, 11:14 PM
Subscribers
None

Details

Summary

Ref T13591. This is an old flag with an old name, and there's an import bug because the outdated concept of "closable" is confusing two different behaviors.

This flag should mean only "is this commit reachable from a permanent ref?". Rename it to "IMPORTED_PERMANENT" to make that more clear.

Rename the "Unpublished" query to "Permanent" to make that more clear, as well.

Test Plan
  • Grepped for all affected symbols.
  • Queried for all commmits, permament commits, and impermanent commits.
  • Ran repository discovery.
  • See also further changes in this change series for more extensive tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable