Page MenuHomePhabricator

Lift logic for queueing commit import tasks into RepositoryEngine
ClosedPublic

Authored by epriestley on Jan 22 2021, 10:50 PM.
Tags
None
Referenced Files
F13184857: D21516.diff
Sat, May 11, 12:58 AM
Unknown Object (File)
Mon, May 6, 2:43 AM
Unknown Object (File)
Fri, May 3, 1:24 AM
Unknown Object (File)
Sat, Apr 20, 5:30 PM
Unknown Object (File)
Mar 31 2024, 6:43 PM
Unknown Object (File)
Feb 17 2024, 2:10 AM
Unknown Object (File)
Jan 25 2024, 2:29 AM
Unknown Object (File)
Jan 20 2024, 4:42 PM
Subscribers
None

Details

Summary

Ref T13591. There are currently two pathways to queue an import task for a commit: via repository discovery, or via a ref becoming permanent.

These pathways duplicate some logic and have behavioral differences: one does not set objectPHID properly, one does not set the priority correctly.

Unify these pathways, make them both set objectPHID, and make them both use the same priority logic.

Test Plan
  • Discovered refs.
  • See later changes in this series for more complete test cases.

Diff Detail

Repository
rP Phabricator
Branch
repair4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25021
Build 34524: Run Core Tests
Build 34523: arc lint + arc unit