Page MenuHomePhabricator

Rename "IMPORTED_CLOSEABLE" to "IMPORTED_PERMANENT" to clarify the meaning of the flag
ClosedPublic

Authored by epriestley on Jan 22 2021, 9:41 PM.
Tags
None
Referenced Files
F15469955: D21514.id51208.diff
Fri, Apr 4, 6:28 PM
F15469954: D21514.diff
Fri, Apr 4, 6:28 PM
F15451216: D21514.id51213.diff
Fri, Mar 28, 8:48 PM
F15448702: D21514.id51208.diff
Fri, Mar 28, 6:27 AM
F15444041: D21514.id.diff
Thu, Mar 27, 7:28 AM
F15440859: D21514.diff
Wed, Mar 26, 3:03 PM
F15439734: D21514.id51213.diff
Wed, Mar 26, 9:08 AM
F15345485: D21514.id51208.diff
Mon, Mar 10, 10:38 AM
Subscribers
None

Details

Summary

Ref T13591. This is an old flag with an old name, and there's an import bug because the outdated concept of "closable" is confusing two different behaviors.

This flag should mean only "is this commit reachable from a permanent ref?". Rename it to "IMPORTED_PERMANENT" to make that more clear.

Rename the "Unpublished" query to "Permanent" to make that more clear, as well.

Test Plan
  • Grepped for all affected symbols.
  • Queried for all commmits, permament commits, and impermanent commits.
  • Ran repository discovery.
  • See also further changes in this change series for more extensive tests.

Diff Detail

Repository
rP Phabricator
Branch
repair2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25019
Build 34520: Run Core Tests
Build 34519: arc lint + arc unit