Correct a straggling CLI format string after ref selector changes
ClosedPublic
Actions

Authored by epriestley on Jan 20 2021, 11:04 PM.

Tags

None

Referenced Files

	F19072963: D21512.diff
	Dec 1 2025, 12:20 AM

	F19024057: D21512.diff
	Nov 24 2025, 2:22 AM

	F19017669: D21512.id.diff
	Nov 23 2025, 8:41 AM

	F18936897: D21512.id.diff
	Nov 10 2025, 9:31 PM

	F18846996: D21512.diff
	Oct 29 2025, 10:22 PM

	F18845106: D21512.diff
	Oct 29 2025, 9:49 AM

	F18844324: D21512.diff
	Oct 29 2025, 4:38 AM

	F18803325: D21512.id.diff
	Oct 17 2025, 10:46 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13589: Git may interpret refnames as flags in some commands which accept both refs and paths
Commits: rPe7e8ef7e390a: Correct a straggling CLI format string after ref selector changes

Summary

Ref T13589. This is missing a "%s" conversion.

Test Plan

Will view a commit with a diff.

Diff Detail

Repository

rP Phabricator

Branch

git3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25016
Build 34515: Run Core Tests
Build 34514: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 20 2021, 11:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 20 2021, 11:04 PM

Harbormaster failed remote builds in B25016: Diff 51205!

This revision was not accepted when it landed; it landed in state Changes Planned.Jan 20 2021, 11:05 PM

This revision was landed with ongoing or failed builds.

Closed by commit rPe7e8ef7e390a: Correct a straggling CLI format string after ref selector changes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe7e8ef7e390a: Correct a straggling CLI format string after ref selector changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

rawdiff/

DiffusionGitRawDiffQuery.php

2 lines

Diff 51205

View Options

src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php

Correct a straggling CLI format string after ref selector changesClosedPublicActions