" to the default Remarkup ignore list
ClosedPublic
Actions

Authored by epriestley on Jan 11 2021, 6:51 PM.

Details

Reviewers: None
Maniphest Tasks: T13575: PHP built-in webserver fails on POST
Commits: rP04c1f67a020c: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list

Summary

Ref T13575. Particularly with the new Apple silicon, I think there are enough domain collisions for M1, M2, P1, etc., to justify adding them to the default ignore list.

Test Plan

Created a mock, then wrote a comment referencing an object on the list (M1) and an object not on the list (T1). Got text and a link respectively.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 11 2021, 6:51 PM

Harbormaster completed remote builds in B25003: Diff 51190.Jan 11 2021, 6:52 PM

epriestley requested review of this revision.Jan 11 2021, 6:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2021, 6:54 PM

Closed by commit rP04c1f67a020c: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP04c1f67a020c: Add "M<digit>" and "P<digit>" to the default Remarkup ignore list.

epriestley mentioned this in T13575: PHP built-in webserver fails on POST.Jan 11 2021, 8:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorCoreConfigOptions.php

16 lines

Diff 51191

View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Add "M<digit>" and "P<digit>" to the default Remarkup ignore listClosedPublicActions