Differential D21502

Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8
ClosedPublic
Actions

Authored by jrtc27 on Jan 11 2021, 2:06 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13588: PHP 8 Compatibility

Commits

rARCf64eb04300b4: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8

Summary

PHP 8 deprecates openssl_free_key as the key is automatically freed, so
silence the warning in PhutilOAuth1Future::signString.

Test Plan

Ran arc lint --everything

Diff Detail

Repository

rARC Arcanist

Branch

php-8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24986
Build 34476: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jan 11 2021, 2:06 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2021, 2:06 AM

jrtc27 requested review of this revision.Jan 11 2021, 2:06 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 11 2021, 2:06 AM

Harbormaster completed remote builds in B24986: Diff 51173.Jan 11 2021, 2:06 AM

jrtc27 added a task: T13588: PHP 8 Compatibility.Jan 11 2021, 2:20 AM

Thanks!

This revision is now accepted and ready to land.Jan 11 2021, 3:01 AM

Rebased patch series

Harbormaster completed remote builds in B24995: Diff 51182.Jan 11 2021, 4:47 AM

Closed by commit rARCf64eb04300b4: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8 (authored by jrtc27). · Explain WhyJan 11 2021, 4:50 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rARCf64eb04300b4: Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8.

Revision Contents
Changeset List

Path

Size

src/

future/

oauth/

PhutilOAuth1Future.php

3 lines

Diff 51173

View Options

src/future/oauth/PhutilOAuth1Future.php

Fix PhutilOAuth1FutureTestCase::testOAuth1SigningWithJIRAExamples for PHP 8ClosedPublicActions