In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly
ClosedPublic
Actions

Authored by epriestley on Sep 18 2020, 6:22 PM.

Tags

None

Referenced Files

	F15454253: D21470.diff
	Sat, Mar 29, 5:36 PM

	F15451994: D21470.id51103.diff
	Sat, Mar 29, 1:02 AM

	F15450772: D21470.id51102.diff
	Fri, Mar 28, 6:09 PM

	F15450627: D21470.id.diff
	Fri, Mar 28, 4:47 PM

	F15450424: D21470.diff
	Fri, Mar 28, 3:40 PM

	F15447091: D21470.id.diff
	Thu, Mar 27, 9:49 PM

	F15442962: D21470.diff
	Thu, Mar 27, 1:33 AM

	F15427776: D21470.id51103.diff
	Sun, Mar 23, 4:00 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARC68dba1a2c6d9: (stable) Promote 2020 Week 37
rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…

Summary

See PHI1862. This code calls "execute()" on the future directly, but that skips some steps -- notably, ServiceProfiler hooks.

Call "resolve()", which has the same effect but includes desirable/expected side effects.

Test Plan

Changed a workflow to run "phutil_passthru('ls')", ran it with "--trace". Before: no execution in trace; after: execution in trace.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 18 2020, 6:22 PM

Harbormaster completed remote builds in B24917: Diff 51102.Sep 18 2020, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2020, 6:22 PM

epriestley requested review of this revision.

Closed by commit rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"….

epriestley added a commit: rARC68dba1a2c6d9: (stable) Promote 2020 Week 37.Sep 18 2020, 7:00 PM

Revision Contents
Changeset List

Path

Size

src/

future/

exec/

execx.php

2 lines

Diff 51103

View Options

In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directlyClosedPublicActions