In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly
ClosedPublic
Actions

Authored by epriestley on Sep 18 2020, 6:22 PM.

Details

Reviewers: None
Commits: rARC68dba1a2c6d9: (stable) Promote 2020 Week 37
rARCa716c4e55fdd: In "phutil_passthru()", "resolve()" the future rather than calling "execute()"…

Summary

See PHI1862. This code calls "execute()" on the future directly, but that skips some steps -- notably, ServiceProfiler hooks.

Call "resolve()", which has the same effect but includes desirable/expected side effects.

Test Plan

Changed a workflow to run "phutil_passthru('ls')", ran it with "--trace". Before: no execution in trace; after: execution in trace.

Repository

rARC Arcanist

Branch

resolve1

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2020, 6:22 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

future/

exec/

2 lines