Differential D21466

Fix a slow memory leak in long-lived FutureIterator objects, as used by FuturePool
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 7:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jun 5 2025, 5:03 PM

	Unknown Object (File)
	May 18 2025, 9:18 PM

	Unknown Object (File)
	Apr 27 2025, 7:47 PM

	Unknown Object (File)
	Apr 27 2025, 5:30 PM

	Unknown Object (File)
	Apr 27 2025, 1:56 PM

	Unknown Object (File)
	Apr 26 2025, 3:34 PM

	Unknown Object (File)
	Apr 26 2025, 12:53 PM

	Unknown Object (File)
	Apr 25 2025, 2:35 PM

Subscribers

None

Details

Reviewers: None
Commits: rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by…

Summary

See T13572. FutureIterator does not release futures, so long-lived iterators (like the one that FuturePool may build) can end up leaking memory.

This affects the FuturePool used by the daemon overseer.

See T13572 for more discussion.

Test Plan

Ran the simple FutureIterator script from T13572. Before: memory held during iteration, script grows without bound. After: memory released, script uses stable memory.
Ran the overseer with memory logging and an immediate wakeup from hibernation. Before: saw memory usage grow without bound at a rate of ~300MB/day. After: saw memory usage stable.

Diff Detail

Repository

Branch

leak1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24909
Build 34365: Run Core Tests
Build 34364: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 17 2020, 7:52 PM

Harbormaster completed remote builds in B24909: Diff 51094.Sep 17 2020, 7:53 PM

epriestley requested review of this revision.Sep 17 2020, 7:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 7:56 PM

Closed by commit rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by….

epriestley added a commit: rARC8e5e49984d50: Fix a slow memory leak in long-lived FutureIterator objects, as used by….

epriestley mentioned this in D21478: Fix a typo of "previously" in FutureIterator.Oct 16 2020, 7:31 PM

epriestley mentioned this in rARC4b3baca999a4: Fix a typo of "previously" in FutureIterator.Oct 16 2020, 9:23 PM

epriestley mentioned this in T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool.Apr 20 2022, 7:22 PM

Revision Contents
Changeset List

Path

Size

src/

future/

FutureIterator.php

9 lines

Diff 51094

src/future/FutureIterator.php

Loading...