Paths

Table of Contentst

Differential D21458

Fix a view fatal in CommitGraphView when commits are undiscovered
ClosedPublic
Actions

Authored by epriestley on Sep 8 2020, 7:55 PM.

Tags

None

Referenced Files

	F14800741: D21458.id51087.diff
	Sat, Jan 25, 8:41 AM

	F14800740: D21458.id51068.diff
	Sat, Jan 25, 8:40 AM

	F14800737: D21458.id.diff
	Sat, Jan 25, 8:40 AM

	F14800736: D21458.diff
	Sat, Jan 25, 8:40 AM

	Unknown Object (File)
	Tue, Jan 21, 11:45 AM

	Unknown Object (File)
	Tue, Jan 21, 10:00 AM

	Unknown Object (File)
	Fri, Jan 17, 2:37 PM

	Unknown Object (File)
	Sat, Jan 11, 5:03 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered

Summary

Ref T13552. See https://discourse.phabricator-community.org/t/viewing-repository-history-for-svn-repository-causes-unhandled-exception/4225/.

This condition is flipped and can fatal by passing a NULL value for $commit to a typehinted method.

Test Plan

Viewed history page with undiscovered commits.

Diff Detail

Repository

Branch

cref10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24883
Build 34330: Run Core Tests
Build 34329: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 8 2020, 7:55 PM

Harbormaster completed remote builds in B24883: Diff 51068.Sep 8 2020, 7:56 PM

epriestley requested review of this revision.Sep 8 2020, 7:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM

Closed by commit rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionCommitGraphView.php

2 lines

Diff 51068

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...