When printing timestamps on paper: use an absolute, context-free date format
ClosedPublic
Actions

Authored by epriestley on Sep 4 2020, 11:25 PM.

Details

Reviewers: None
Maniphest Tasks: T13573: When printing, render dates in an absolute, context-free format
Commits: rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date…
rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format

Summary

Ref T13573. Using the browser "Print" feature on pages produces "Thu, Aug 4, 12:22" timestamps which require context to interpret precisely (they don't have a year and don't have a timezone).

Instead, retain these timestamps in "screen" contexts but use "YYYY-MM-DD HH:MM:SS (UTC+X)" timestamps when printing.

Test Plan

Printed Maniphest tasks and other pages in Safari and Chrome using "?print=1" and "Print to PDF", saw absolute timestamps after this chagne in the printed documents.

Diff Detail

Repository

rP Phabricator

Branch

date1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 24866
Build 34305: Run Core Tests
Build 34304: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	465 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: function.phabricator_absolute_datetime, function.phabricator_dual_datetime.
	5,310 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: function.phabricator_absolute_datetime, function.phabricator_dual_datetime.
	1 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPHeaderParserTestCase::testHeaderParser 18 assertions passed.
		View Full Test Results (2 Failed · 435 Passed · 2 Skipped)