Page MenuHomePhabricator
Differential D21449

Make "CommitData" wrap and persist a "CommitRef" record
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 8:02 PM.
Tags
None
Referenced Files
F15462900: D21449.id51048.diff
Tue, Apr 1, 6:44 PM
F15443051: D21449.id51048.diff
Thu, Mar 27, 1:57 AM
F15440285: D21449.id51085.diff
Wed, Mar 26, 11:54 AM
F15437862: D21449.id.diff
Tue, Mar 25, 9:51 PM
F15431430: D21449.diff
Mon, Mar 24, 12:16 PM
F15422317: D21449.id51048.diff
Sat, Mar 22, 7:14 AM
F15412250: D21449.diff
Wed, Mar 19, 12:00 PM
F15408408: D21449.diff
Tue, Mar 18, 10:51 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record
Summary

Ref T13552. Turn "CommitData" into an application-level layer on top of the repository-level "CommitRef" object.

For older commits which will not have a "CommitRef" record on disk, build a synthetic one at runtime. This could eventually be migrated.

Test Plan

Ran "bin/repository reparse --message", browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
cref8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24863
Build 34300: Run Core Tests
Build 34299: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 8:02 PM
Harbormaster completed remote builds in B24863: Diff 51048.Aug 12 2020, 8:03 PM
epriestley requested review of this revision.Aug 12 2020, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
Closed by commit rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
data/
4 lines
repository/
storage/
5 lines
57 lines
worker/
20 lines
commitmessageparser/
46 lines

Diff 51048

View Options

src/applications/diffusion/data/DiffusionCommitRef.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility