Page MenuHomePhabricator
Differential D21418

Improve desktop and mobile layouts for new "CommitGridView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 9:26 PM.
Tags
None
Referenced Files
F15458321: D21418.diff
Sun, Mar 30, 11:02 PM
F15448530: D21418.id51035.diff
Fri, Mar 28, 5:28 AM
F15445764: D21418.id50963.diff
Thu, Mar 27, 3:53 PM
F15434989: D21418.id.diff
Tue, Mar 25, 6:17 AM
F15433696: D21418.diff
Tue, Mar 25, 12:18 AM
F15428313: D21418.diff
Sun, Mar 23, 7:13 PM
F15399044: D21418.id50963.diff
Mon, Mar 17, 2:34 AM
F15380503: D21418.diff
Fri, Mar 14, 3:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP57f9450bcfc0: Improve desktop and mobile layouts for new "CommitGridView"
Summary

Ref T13552. The current layout doesn't work particularly well on desktops or devices.

We have some device/desktop table layout code, but it isn't generic. We also have property list layout code, but it isn't generic either.

Provide generic layout elements ("Fuel", from "Phabricator UI Layout" to "PHUIL"?) and narrowly specialize their display behavior. Then swap the ListItemView stuff to use it.

Test Plan

Saw slightly better responsive behavior:

Screen Shot 2020-07-12 at 2.25.14 PM.png (145×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 12 2020, 9:26 PM
Harbormaster completed remote builds in B24783: Diff 50963.Jul 12 2020, 9:27 PM
epriestley requested review of this revision.Jul 12 2020, 9:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
Closed by commit rP57f9450bcfc0: Improve desktop and mobile layouts for new "CommitGridView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP57f9450bcfc0: Improve desktop and mobile layouts for new "CommitGridView".

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
diffusion/
view/
20 lines
view/
fuel/
35 lines
28 lines
32 lines
41 lines
54 lines
45 lines
10 lines
phui/
29 lines
webroot/
rsrc/
css/
fuel/
29 lines
71 lines

Diff 51035

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
View Options

src/view/fuel/FuelComponentView.php

Loading...
View Options

src/view/fuel/FuelGridCellView.php

Loading...
View Options

src/view/fuel/FuelGridRowView.php

Loading...
View Options

src/view/fuel/FuelGridView.php

Loading...
View Options

src/view/fuel/FuelMapItemView.php

Loading...
View Options

src/view/fuel/FuelMapView.php

Loading...
View Options

src/view/fuel/FuelView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/fuel/fuel-grid.css

Loading...
View Options

webroot/rsrc/css/fuel/fuel-map.css

Loading...
Phabricator · Built by Phacility