Page MenuHomePhabricator
Differential D21420

Likely, fix a warning when rendering modified coverage
ClosedPublic
Actions

Authored by epriestley on Jul 18 2020, 2:44 AM.
Tags
None
Referenced Files
F15470348: D21420.diff
Fri, Apr 4, 9:38 PM
F15454121: D21420.diff
Sat, Mar 29, 4:26 PM
F15433146: D21420.id50967.diff
Mon, Mar 24, 9:42 PM
F15331688: D21420.id50967.diff
Fri, Mar 7, 12:41 PM
F15331578: D21420.id.diff
Fri, Mar 7, 11:36 AM
F15331359: D21420.diff
Fri, Mar 7, 9:18 AM
F15286033: D21420.id50966.diff
Mar 4 2025, 5:38 PM
Unknown Object (File)
Mar 2 2025, 6:02 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage
rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage
Summary

See PHI1819. This structure may have null elements.

Test Plan

Will confirm user reproduction case.

Diff Detail

Repository
rP Phabricator
Branch
coverage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24786
Build 34193: Run Core Tests
Build 34192: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 18 2020, 2:44 AM
Harbormaster completed remote builds in B24786: Diff 50966.Jul 18 2020, 2:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 18 2020, 2:45 AM
epriestley requested review of this revision.
Closed by commit rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0ed5569e9f7b: Likely, fix a warning when rendering modified coverage.
epriestley added a commit: rPd32c3f8d7d65: (stable) Likely, fix a warning when rendering modified coverage.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
4 lines

Diff 50966

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
Phabricator · Built by Phacility