Page MenuHomePhabricator

Improve desktop and mobile layouts for new "CommitGridView"
ClosedPublic

Authored by epriestley on Jul 12 2020, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 5:35 AM
Unknown Object (File)
Fri, Nov 22, 3:41 PM
Unknown Object (File)
Sep 30 2024, 9:31 PM
Unknown Object (File)
Sep 24 2024, 2:33 PM
Unknown Object (File)
Sep 15 2024, 3:00 PM
Unknown Object (File)
Sep 8 2024, 10:12 AM
Unknown Object (File)
Sep 8 2024, 10:11 AM
Unknown Object (File)
Sep 6 2024, 8:25 AM
Subscribers
None

Details

Summary

Ref T13552. The current layout doesn't work particularly well on desktops or devices.

We have some device/desktop table layout code, but it isn't generic. We also have property list layout code, but it isn't generic either.

Provide generic layout elements ("Fuel", from "Phabricator UI Layout" to "PHUIL"?) and narrowly specialize their display behavior. Then swap the ListItemView stuff to use it.

Test Plan

Saw slightly better responsive behavior:

Screen Shot 2020-07-12 at 2.25.14 PM.png (145×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
publish15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24783
Build 34188: Run Core Tests
Build 34187: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.