Differential D21397

Preserve bookmarks across "hg rebase --keep --collapse", and destroy them before "hg strip/prune"
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 11:21 PM.

Tags

None

Referenced Files

	F19661096: D21397.id50933.diff
	Sat, Feb 7, 5:46 AM

	F19617573: D21397.id50933.diff
	Wed, Feb 4, 6:36 AM

	F19609701: D21397.id.diff
	Tue, Feb 3, 1:57 PM

	F19525240: D21397.id50933.diff
	Sun, Jan 18, 7:26 AM

	F19385270: D21397.id50933.diff
	Dec 27 2025, 2:06 AM

	F19315027: D21397.id.diff
	Dec 25 2025, 3:17 AM

	F19304190: D21397.diff
	Dec 24 2025, 7:48 AM

	F18879514: D21397.diff
	Nov 6 2025, 6:31 PM

Subscribers

None

Details

Reviewers: None
Commits: rARC2565cc7b4d1d: (stable) Promote 2020 Week 27
rARC65cda1596f25: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them…

Summary

See PHI1808. Currently, "arc land <some bookmark>" does not destroy the bookmark in Mercurial. There are three issues here:

"hg rebase --keep --collapse" moves bookmarks to the rewritten commits;
"hg strip" moves bookmarks backwards;
"hg prune" moves bookmarks backwards.

To get around "hg rebase", save and restore bookmark state.

To get around "hg strip" and "hg prune", explicitly destroy bookmarks pointing at commits before we strip/prune those commits.

Test Plan

Ran "arc land <some bookmark> --trace". Saw arc reset the bookmark position after rebasing, and destroy the bookmark explicitly before stripping.
When the workflow exited, saw no more bookmark (previously: bookmark existed and pointed at a possibly-intermediate state).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 8 2020, 11:21 PM

Harbormaster completed remote builds in B24752: Diff 50933.Jul 8 2020, 11:21 PM

epriestley requested review of this revision.Jul 8 2020, 11:21 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 12:43 AM

Closed by commit rARC65cda1596f25: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC65cda1596f25: Preserve bookmarks across "hg rebase --keep --collapse", and destroy them….

epriestley added a commit: rARC2565cc7b4d1d: (stable) Promote 2020 Week 27.Jul 11 2020, 4:34 PM

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistMercurialLandEngine.php

67 lines

Diff 50934

src/land/engine/ArcanistMercurialLandEngine.php

Loading...