Page MenuHomePhabricator
Differential D21387

Improve login/auth messages from Arcanist toolset workflows
ClosedPublic
Actions

Authored by epriestley on Jul 1 2020, 1:14 PM.
Tags
None
Referenced Files
F15460543: D21387.id50912.diff
Mon, Mar 31, 11:50 PM
F15459692: D21387.id50912.diff
Mon, Mar 31, 3:15 PM
F15449408: D21387.id50903.diff
Fri, Mar 28, 10:00 AM
F15446141: D21387.id.diff
Thu, Mar 27, 5:23 PM
F15442741: D21387.diff
Thu, Mar 27, 12:13 AM
F15332549: D21387.diff
Fri, Mar 7, 5:53 PM
F15331744: D21387.id.diff
Fri, Mar 7, 1:19 PM
F15331417: D21387.id50912.diff
Fri, Mar 7, 10:15 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARCb8a5191e3b36: Improve login/auth messages from Arcanist toolset workflows
Summary

See PHI1802. After D21384, "arc land" and similar with no credentials now properly raise a useful exception, but it isn't formatted readably.

Update the display code to make it look prettier.

Test Plan

Ran "arc land" with no and invalid credentials, got properly formatted output.

Diff Detail

Repository
rARC Arcanist
Branch
future6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24721
Build 34093: Run Core Tests
Build 34092: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 1 2020, 1:14 PM
Harbormaster completed remote builds in B24721: Diff 50903.Jul 1 2020, 1:15 PM
epriestley requested review of this revision.Jul 1 2020, 1:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
Closed by commit rARCb8a5191e3b36: Improve login/auth messages from Arcanist toolset workflows (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCb8a5191e3b36: Improve login/auth messages from Arcanist toolset workflows.

Revision Contents
Changeset List

Diff 50903

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/conduit/ArcanistConduitCallFuture.php

Loading...
View Options

src/exception/ArcanistConduitAuthenticationException.php

Loading...
View Options

src/runtime/ArcanistRuntime.php

Loading...
Phabricator · Built by Phacility