Differential D21358

On Windows, don't try to set "stdin" nonblocking, as it does not work
ClosedPublic
Actions

Authored by epriestley on Jun 12 2020, 9:18 PM.

Tags

None

Referenced Files

	F22832078: D21358.diff
	Sun, Oct 11, 3:04 AM

	F22572437: D21358.id50840.diff
	Sat, Sep 26, 8:59 PM

	Unknown Object (File)
	Aug 9 2026, 3:44 AM

	Unknown Object (File)
	Jul 7 2026, 8:23 PM

	Unknown Object (File)
	Jul 1 2026, 8:36 AM

	Unknown Object (File)
	Jun 24 2026, 3:08 PM

	Unknown Object (File)
	Jun 21 2026, 9:54 AM

	Unknown Object (File)
	Apr 21 2026, 12:05 PM

Subscribers

None

Details

Reviewers: None
Commits: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work

Summary

See https://discourse.phabricator-community.org/t/arc-land-fail-unable-to-set-stdin-nonblocking/4006/.

See also https://bugs.php.net/bug.php?id=34972.

Note that you can't ^C during a prompt (or at any other time) in Windows currently, see T13549.

Test Plan

On Windows, hit a prompt in "arc land", then answered it successfully.

Diff Detail

Repository

Branch

win1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24659
Build 34001: Run Core Tests
Build 34000: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 12 2020, 9:18 PM

Harbormaster completed remote builds in B24659: Diff 50839.Jun 12 2020, 9:18 PM

epriestley requested review of this revision.Jun 12 2020, 9:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2020, 9:29 PM

Closed by commit rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC33dfa859d8e6: On Windows, don't try to set "stdin" nonblocking, as it does not work.

Revision Contents
Changeset List

Path

Size

src/

toolset/

ArcanistPrompt.php

80 lines

Diff 50839

src/toolset/ArcanistPrompt.php

Loading...