Remove "haveUncommittedChanges" property from "arc diff"
ClosedPublic
Actions

Authored by epriestley on May 30 2020, 10:26 PM.

Tags

None

Referenced Files

	F15465835: D21299.id50715.diff
	Wed, Apr 2, 11:38 PM

	F15465190: D21299.id50741.diff
	Wed, Apr 2, 3:52 PM

	F15462597: D21299.id.diff
	Tue, Apr 1, 4:16 PM

	F15460697: D21299.diff
	Tue, Apr 1, 1:20 AM

	F15417289: D21299.id50741.diff
	Thu, Mar 20, 4:30 PM

	F15331988: D21299.diff
	Mar 7 2025, 3:48 PM

	Unknown Object (File)
	Mar 4 2025, 12:01 AM

	Unknown Object (File)
	Feb 16 2025, 6:55 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow
Commits: rARCbb81172eb7fd: Remove "haveUncommittedChanges" property from "arc diff"

Summary

Ref T13544. This property is private and has no writers.

Test Plan

Grepped for symbol.

Diff Detail

Repository

rARC Arcanist

Branch

xdiff4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24537
Build 33816: Run Core Tests
Build 33815: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:26 PM

Harbormaster completed remote builds in B24537: Diff 50715.May 30 2020, 10:26 PM

epriestley requested review of this revision.May 30 2020, 10:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 8:26 PM

Closed by commit rARCbb81172eb7fd: Remove "haveUncommittedChanges" property from "arc diff" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCbb81172eb7fd: Remove "haveUncommittedChanges" property from "arc diff".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

5 lines

Diff 50715

View Options

src/workflow/ArcanistDiffWorkflow.php

Remove "haveUncommittedChanges" property from "arc diff"ClosedPublicActions