Mark the wildcard argument to "arc liberate" as a path argument for shell completion
ClosedPublic
Actions

Authored by epriestley on May 28 2020, 2:25 PM.

Tags

None

Referenced Files

	F14596156: D21292.id50704.diff
	Wed, Jan 8, 7:19 PM

	Unknown Object (File)
	Mon, Jan 6, 3:37 PM

	Unknown Object (File)
	Mon, Dec 30, 6:19 PM

	Unknown Object (File)
	Mon, Dec 23, 7:40 AM

	Unknown Object (File)
	Mon, Dec 23, 1:50 AM

	Unknown Object (File)
	Fri, Dec 20, 3:43 PM

	Unknown Object (File)
	Tue, Dec 17, 8:34 PM

	Unknown Object (File)
	Sun, Dec 15, 5:58 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell…

Summary

This is a path argument, and shell completion should suggest tabs.

Test Plan

Typed "arc liberate s<tab>", got path suggestions.

Diff Detail

Repository

rARC Arcanist

Branch

lib1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24524
Build 33796: Run Core Tests
Build 33795: arc lint + arc unit

Event Timeline

epriestley created this revision.May 28 2020, 2:25 PM

Harbormaster completed remote builds in B24524: Diff 50704.May 28 2020, 2:25 PM

epriestley requested review of this revision.May 28 2020, 2:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 2:33 PM

Closed by commit rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell….

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLiberateWorkflow.php

3 lines

Diff 50704

View Options

src/workflow/ArcanistLiberateWorkflow.php

Mark the wildcard argument to "arc liberate" as a path argument for shell completionClosedPublicActions