Mark the wildcard argument to "arc liberate" as a path argument for shell completion
ClosedPublic
Actions

Authored by epriestley on May 28 2020, 2:25 PM.

Tags

None

Referenced Files

	F18101124: D21292.diff
	Sat, Aug 9, 12:20 PM

	F18087291: D21292.diff
	Wed, Aug 6, 3:19 AM

	F18084089: D21292.diff
	Tue, Aug 5, 1:38 PM

	Unknown Object (File)
	Jun 14 2025, 3:04 AM

	Unknown Object (File)
	May 6 2025, 5:23 AM

	Unknown Object (File)
	Apr 30 2025, 1:07 PM

	Unknown Object (File)
	Apr 29 2025, 9:05 PM

	Unknown Object (File)
	Apr 28 2025, 4:51 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell…

Summary

This is a path argument, and shell completion should suggest tabs.

Test Plan

Typed "arc liberate s<tab>", got path suggestions.

Diff Detail

Repository

rARC Arcanist

Branch

lib1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24524
Build 33796: Run Core Tests
Build 33795: arc lint + arc unit

Event Timeline

epriestley created this revision.May 28 2020, 2:25 PM

Harbormaster completed remote builds in B24524: Diff 50704.May 28 2020, 2:25 PM

epriestley requested review of this revision.May 28 2020, 2:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 2:33 PM

Closed by commit rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc76cfc8c82c0: Mark the wildcard argument to "arc liberate" as a path argument for shell….

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLiberateWorkflow.php

3 lines

Diff 50704

View Options

src/workflow/ArcanistLiberateWorkflow.php

Mark the wildcard argument to "arc liberate" as a path argument for shell completionClosedPublicActions