Page MenuHomePhabricator

Fix an issue when rendering a lint message which removes whitespace at the end of a file
ClosedPublic

Authored by epriestley on May 27 2020, 6:26 PM.
Tags
None
Referenced Files
F14112424: D21290.diff
Thu, Nov 28, 1:19 AM
F14108992: D21290.id50699.diff
Wed, Nov 27, 1:11 PM
Unknown Object (File)
Tue, Nov 26, 7:36 AM
Unknown Object (File)
Sun, Nov 24, 9:58 AM
Unknown Object (File)
Thu, Nov 21, 9:12 AM
Unknown Object (File)
Sun, Nov 17, 10:51 AM
Unknown Object (File)
Sun, Nov 17, 9:56 AM
Unknown Object (File)
Sun, Nov 17, 9:20 AM
Subscribers
None

Details

Summary

Ref T13543. If a file ends in spaces and no newline, we'll emit a message suggesting removal of the spaces. This will effectively remove the line, but the code will then attempt to highlight text within the line.

Prior to D21044 this continued without raising an error and produced a reasonable result, but it now fatals. Insetad, don't try to highlight lines which no longer exist.

Test Plan

See T13543 for details.

Diff Detail

Repository
rARC Arcanist
Branch
white1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24519
Build 33789: Run Core Tests
Build 33788: arc lint + arc unit