Page MenuHomePhabricator

Clean up Diffusion behaviors for inline edit suggestions
ClosedPublic

Authored by epriestley on May 20 2020, 4:22 PM.
Tags
None
Referenced Files
F15456688: D21278.diff
Sun, Mar 30, 11:23 AM
F15400574: D21278.id50672.diff
Mon, Mar 17, 12:38 PM
Unknown Object (File)
Sun, Mar 2, 7:52 AM
Unknown Object (File)
Feb 24 2025, 2:45 AM
Unknown Object (File)
Feb 22 2025, 5:12 PM
Unknown Object (File)
Feb 20 2025, 1:05 AM
Unknown Object (File)
Feb 9 2025, 9:22 AM
Unknown Object (File)
Feb 9 2025, 9:22 AM
Subscribers
None

Details

Summary

Ref T13513. For now, I'm not supporting inline edit suggestions in Diffusion, although it's likely not difficult to do so in the future. Clean up some of the code so that plain ol' inlines work the same way they did before.

Test Plan
  • Created, edited, reloaded, submitted inlines in Diffusion: familiar old behavior.
  • Created, edited, reloaded, submitted inlines with suggestions in Differential: familiar new behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:28 PM
This revision was automatically updated to reflect the committed changes.