Page MenuHomePhabricator

Allow "has draft inlines?" queries to overheat
ClosedPublic

Authored by epriestley on May 19 2020, 8:54 PM.
Tags
None
Referenced Files
F13162832: D21274.id50668.diff
Mon, May 6, 4:00 PM
F13159350: D21274.id50659.diff
Mon, May 6, 1:33 AM
Unknown Object (File)
Sat, May 4, 11:03 PM
Unknown Object (File)
Fri, May 3, 6:19 PM
Unknown Object (File)
Fri, May 3, 10:00 AM
Unknown Object (File)
Fri, May 3, 7:50 AM
Unknown Object (File)
Thu, Apr 25, 1:48 AM
Unknown Object (File)
Tue, Apr 23, 6:51 PM
Subscribers
None

Details

Summary

Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development.

For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps.

Test Plan
  • Created and deleted 10 inlines.
  • Submitted comments.
  • Before: overheating fatal during draft flag generation.
  • After: clean submission.

Diff Detail

Repository
rP Phabricator
Branch
inline8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24478
Build 33730: Run Core Tests
Build 33729: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:25 PM
This revision was automatically updated to reflect the committed changes.