Page MenuHomePhabricator
Differential D21264

Fix an email address validation UI feedback issue when creating new users
ClosedPublic
Actions

Authored by epriestley on May 18 2020, 2:33 PM.
Tags
None
Referenced Files
F15512176: D21264.id50634.diff
Thu, Apr 17, 8:35 AM
F15491452: D21264.diff
Sat, Apr 12, 3:39 AM
F15487081: D21264.id50634.diff
Thu, Apr 10, 11:02 AM
F15483770: D21264.id50635.diff
Wed, Apr 9, 2:18 PM
F15481618: D21264.id.diff
Tue, Apr 8, 10:14 PM
F15476836: D21264.diff
Mon, Apr 7, 9:46 AM
F15463667: D21264.diff
Wed, Apr 2, 2:07 AM
F15447410: D21264.id50634.diff
Thu, Mar 27, 11:40 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users
Summary

On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message.

Test Plan
  • Before: Tried to create a new user with address "asdf". Got no specific guidance.
  • After: Got specific guidance about email address formatting and length.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 18 2020, 2:33 PM
Harbormaster completed remote builds in B24453: Diff 50634.May 18 2020, 2:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 2:34 PM
epriestley requested review of this revision.
Closed by commit rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
5 lines

Diff 50635

View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Loading...
Phabricator · Built by Phacility