Fix an email address validation UI feedback issue when creating new users
ClosedPublic
Actions

Authored by epriestley on May 18 2020, 2:33 PM.

Tags

None

Referenced Files

	F18855263: D21264.id50634.diff
	Nov 1 2025, 4:38 AM

	F18815653: D21264.id.diff
	Oct 21 2025, 3:06 AM

	F18804565: D21264.diff
	Oct 18 2025, 9:43 AM

	F18626124: D21264.id.diff
	Sep 16 2025, 12:23 AM

	F18608724: D21264.diff
	Sep 14 2025, 1:35 AM

	F18600522: D21264.diff
	Sep 13 2025, 9:56 AM

	F18434383: D21264.diff
	Aug 31 2025, 9:15 AM

	F18110946: D21264.id.diff
	Aug 12 2025, 3:00 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users

Summary

On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message.

Test Plan

Before: Tried to create a new user with address "asdf". Got no specific guidance.
After: Got specific guidance about email address formatting and length.

Diff Detail

Repository

rP Phabricator

Branch

error1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24453
Build 33695: Run Core Tests
Build 33694: arc lint + arc unit

Event Timeline

epriestley created this revision.May 18 2020, 2:33 PM

Harbormaster completed remote builds in B24453: Diff 50634.May 18 2020, 2:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 18 2020, 2:34 PM

epriestley requested review of this revision.

Closed by commit rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleNewController.php

5 lines

Diff 50634

View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

Fix an email address validation UI feedback issue when creating new usersClosedPublicActions