Fix an out-of-order access issue with inlines
ClosedPublic
Actions

Authored by epriestley on May 15 2020, 8:27 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPb24bac5afbd4: (stable) Fix an out-of-order access issue with inlines
rP93b08f0e83e6: Fix an out-of-order access issue with inlines

Summary

Ref T13513. On secure, I caught an issue where inlines may be accessed directly before they're constructed. Instead, access them through the relevant accessor.

Test Plan

Will deploy.

Diff Detail

Repository

rP Phabricator

Branch

inlines1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24450
Build 33691: Run Core Tests
Build 33690: arc lint + arc unit

Event Timeline

epriestley created this revision.May 15 2020, 8:27 PM

Harbormaster completed remote builds in B24450: Diff 50631.May 15 2020, 8:28 PM

epriestley requested review of this revision.May 15 2020, 8:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 8:56 PM

Closed by commit rP93b08f0e83e6: Fix an out-of-order access issue with inlines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP93b08f0e83e6: Fix an out-of-order access issue with inlines.

epriestley added a commit: rPb24bac5afbd4: (stable) Fix an out-of-order access issue with inlines.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

8 lines

Diff 50631

View Options

resources/celerity/map.php