Page MenuHomePhabricator

Use a more consistent inline highlighting style with fewer redraws
ClosedPublic

Authored by epriestley on May 15 2020, 7:42 PM.
Tags
None
Referenced Files
F13277509: D21262.diff
Fri, May 31, 11:12 AM
F13270362: D21262.diff
Wed, May 29, 9:33 AM
F13221836: D21262.diff
Sun, May 19, 3:05 AM
F13204375: D21262.diff
Wed, May 15, 12:31 AM
F13201645: D21262.id50630.diff
Tue, May 14, 2:02 PM
F13192518: D21262.id50629.diff
Sun, May 12, 8:26 AM
F13187291: D21262.diff
Sat, May 11, 4:26 AM
Unknown Object (File)
Tue, May 7, 7:34 AM
Subscribers
None

Details

Summary

Ref T13513. The on-hover-inline reticle has switched over to have cell-based behavior. Switch the on-hover-line-number reticle to use the same behavior.

Also, clean up the dirty/redraw loop slightly: we no longer need to dirty on resize, and we don't need to redraw if the range isn't actually dirty.

Test Plan

Highlighted lines and line ranges. Hovered over inlines.

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24446
Build 33686: Run Core Tests
Build 33685: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2020, 7:44 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.