Page MenuHomePhabricator

When users click headers to select diff UI elements, don't eat the events
ClosedPublic

Authored by epriestley on May 14 2020, 6:46 PM.
Tags
None
Referenced Files
F13152822: D21255.id50611.diff
Sat, May 4, 10:03 PM
Unknown Object (File)
Fri, May 3, 7:39 AM
Unknown Object (File)
Sun, Apr 28, 10:11 PM
Unknown Object (File)
Sun, Apr 28, 10:22 AM
Unknown Object (File)
Sat, Apr 27, 6:29 AM
Unknown Object (File)
Thu, Apr 25, 1:39 AM
Unknown Object (File)
Tue, Apr 23, 5:46 PM
Unknown Object (File)
Fri, Apr 19, 3:34 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, clicking inline or changeset headers eats the click events. This doesn't serve any clear purpose, and means these clicks do not clear text selections from the document, which is unusual.

Test Plan
  • Selected some text in a diff.
  • Clicked a changeset header to select it.
  • Before patch: text selection and context menu were retained.
  • After patch: text selection was cleared and context menu was dismissed.

Diff Detail

Repository
rP Phabricator
Branch
inline4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24428
Build 33661: Run Core Tests
Build 33660: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:34 PM
This revision was automatically updated to reflect the committed changes.