Differential D21248

Allow users to create inline comments by directly selecting text directly
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 8:17 PM.

Tags

None

Referenced Files

	F18950499: D21248.id.diff
	Wed, Nov 12, 2:33 AM

	F18949467: D21248.diff
	Wed, Nov 12, 12:57 AM

	F18869657: D21248.diff
	Tue, Nov 4, 12:52 PM

	F18703625: D21248.id.diff
	Sep 28 2025, 4:35 AM

	F18646483: D21248.id50598.diff
	Sep 19 2025, 10:11 AM

	F18629815: D21248.diff
	Sep 16 2025, 9:59 AM

	F18617862: D21248.diff
	Sep 14 2025, 10:24 PM

	F18494746: D21248.id50603.diff
	Sep 4 2025, 3:00 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP42378ea393fe: Allow users to create inline comments by directly selecting text directly

Summary

Ref T13513. Support direct text selection for inlines. This is currently just an alternate way to get to the same place as using line numbers, but can preserve offset/range information in the future.

Test Plan

Selected some text, hit "c", clicked "New Inline Comment", got sensible comments on both sides of a diff in Safari, Chrome, and (with limitations) Firefox.
Caveats: no unified support, doesn't work across lines in Firefox.

Diff Detail

Repository

Branch

engine7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24415
Build 33641: Run Core Tests
Build 33640: arc lint + arc unit

Event Timeline

epriestley created this revision.May 13 2020, 8:17 PM

Harbormaster completed remote builds in B24415: Diff 50598.May 13 2020, 8:18 PM

epriestley requested review of this revision.May 13 2020, 8:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:15 AM

Closed by commit rP42378ea393fe: Allow users to create inline comments by directly selecting text directly (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP42378ea393fe: Allow users to create inline comments by directly selecting text directly.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

view/

DifferentialChangesetListView.php

8 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

298 lines

core/

behavior-oncopy.js

2 lines

phuix/

PHUIXDropdownMenu.js

84 lines

Diff 50598

resources/celerity/map.php

Loading...

src/applications/differential/view/DifferentialChangesetListView.php

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...

webroot/rsrc/js/core/behavior-oncopy.js

Loading...

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Loading...