Page MenuHomePhabricator

Lift most "InlineController" querying to the base class
ClosedPublic

Authored by epriestley on May 7 2020, 7:54 PM.
Tags
None
Referenced Files
F15535204: D21231.diff
Thu, Apr 24, 3:59 AM
F15524026: D21231.diff
Mon, Apr 21, 5:32 AM
F15464120: D21231.diff
Wed, Apr 2, 6:34 AM
F15459665: D21231.id50556.diff
Mon, Mar 31, 3:00 PM
F15456717: D21231.id50567.diff
Sun, Mar 30, 11:39 AM
F15454523: D21231.id.diff
Sat, Mar 29, 6:57 PM
F15449934: D21231.diff
Fri, Mar 28, 12:59 PM
F15447450: D21231.id.diff
Thu, Mar 27, 11:56 PM
Subscribers
None

Details

Summary

Ref T13513. Move querying to "DiffInlineCommentQuery" classes and lift them into the base Controller.

Test Plan

In Differential and Diffusion, created, edited, and submitted inline comments.

Diff Detail

Repository
rP Phabricator
Branch
iquery8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24372
Build 33579: Run Core Tests
Build 33578: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:04 PM
This revision was automatically updated to reflect the committed changes.