Page MenuHomePhabricator
Differential D21219

When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:53 PM
Unknown Object (File)
Jun 2 2025, 10:43 AM
Unknown Object (File)
Jun 1 2025, 9:30 PM
Unknown Object (File)
May 31 2025, 4:35 PM
Unknown Object (File)
May 7 2025, 8:53 PM
Unknown Object (File)
Apr 30 2025, 4:41 PM
Unknown Object (File)
Apr 6 2025, 11:38 PM
Unknown Object (File)
Apr 2 2025, 12:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP07e160bde1e8: When cancelling an unsaved editing inline after a reload, don't cancel into an…
Summary

Ref T13513. Overloading "original text" to get "edit-on-load" comments into the right state has some undesirable side effects.

Instead, provide the text when the editor opens. This fixes a cancel interaction.

Test Plan
  • Create an inline, type text, don't save.
  • Reload page.
  • Cancel.
  • Before: cancelled into empty state.
  • After: cancelled into deleted+undo state.

Diff Detail

Repository
rP Phabricator
Branch
focus3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24349
Build 33544: Run Core Tests
Build 33543: arc lint + arc unit

Event Timeline

epriestley created this revision.May 4 2020, 9:01 PM
Harbormaster completed remote builds in B24349: Diff 50532.May 4 2020, 9:02 PM
epriestley requested review of this revision.May 4 2020, 9:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:20 PM
Closed by commit rP07e160bde1e8: When cancelling an unsaved editing inline after a reload, don't cancel into an… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP07e160bde1e8: When cancelling an unsaved editing inline after a reload, don't cancel into an….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
infrastructure/
diff/
8 lines
view/
2 lines
4 lines
webroot/
rsrc/
js/
application/
diff/
2 lines

Diff 50532

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility