Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
F15417814: D21214.diff
Thu, Mar 20, 6:47 PM
F15416293: D21214.id50527.diff
Thu, Mar 20, 10:24 AM
F15410033: D21214.diff
Wed, Mar 19, 6:43 AM
F15341132: D21214.diff
Sun, Mar 9, 6:43 PM
F15338151: D21214.id50527.diff
Sun, Mar 9, 9:34 AM
F15332552: D21214.diff
Fri, Mar 7, 5:54 PM
F15316118: D21214.id50527.diff
Thu, Mar 6, 6:22 PM
F15316116: D21214.id50517.diff
Thu, Mar 6, 6:22 PM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.