Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
F14820087: D21214.id50527.diff
Tue, Jan 28, 4:34 AM
Unknown Object (File)
Sat, Jan 25, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 7:31 AM
Unknown Object (File)
Sat, Jan 25, 7:30 AM
Unknown Object (File)
Wed, Jan 22, 2:44 AM
Unknown Object (File)
Wed, Jan 15, 9:02 PM
Unknown Object (File)
Mon, Jan 13, 10:34 AM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Branch
inline8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24334
Build 33524: Run Core Tests
Build 33523: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.