Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
F14121295: D21214.diff
Fri, Nov 29, 12:07 PM
Unknown Object (File)
Mon, Nov 18, 8:17 PM
Unknown Object (File)
Thu, Nov 14, 6:35 PM
Unknown Object (File)
Sun, Nov 10, 10:32 PM
Unknown Object (File)
Thu, Nov 7, 7:33 AM
Unknown Object (File)
Oct 20 2024, 9:44 AM
Unknown Object (File)
Oct 14 2024, 3:28 AM
Unknown Object (File)
Oct 5 2024, 11:52 AM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Branch
inline8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24334
Build 33524: Run Core Tests
Build 33523: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.