When creating a File storage object for a Paste, try to give it the same name as the Paste
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 1:57 PM.

Details

Reviewers: None
Maniphest Tasks: T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available
Commits: rPd6928a3c2679: When creating a File storage object for a Paste, try to give it the same name…

Summary

Ref T13528. Paste data is stored in files, but the files are always named "raw.txt".

Now that Paste provides a hint to use Files for "DocumentEngine" rendering, try to use the same name as the paste instead.

Test Plan

Created a paste named "staggering-insight.ipynb".
Clicked "View as Jupyter Notebook" from Paste.
Saw a file named "staggering-insight.ipynb", not "raw.txt".
Created a paste with no name, saw a file named "raw-paste-data.txt" get created.

Diff Detail

Repository

rP Phabricator

Branch

paste2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24296
Build 33469: Run Core Tests
Build 33468: arc lint + arc unit

Event Timeline

epriestley created this revision.May 1 2020, 1:57 PM

Harbormaster completed remote builds in B24296: Diff 50481.May 1 2020, 1:58 PM

epriestley requested review of this revision.May 1 2020, 1:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:10 PM

Closed by commit rPd6928a3c2679: When creating a File storage object for a Paste, try to give it the same name… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd6928a3c2679: When creating a File storage object for a Paste, try to give it the same name….

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

editor/

PhabricatorPasteEditor.php

22 lines

xaction/

PhabricatorPasteContentTransaction.php

9 lines

Diff 50481

View Options

src/applications/paste/editor/PhabricatorPasteEditor.php