Differential D21187

When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change
ClosedPublic
Actions

Authored by epriestley on Apr 29 2020, 6:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 9:09 AM

	Unknown Object (File)
	Sun, Feb 9, 9:09 AM

	Unknown Object (File)
	Sun, Feb 9, 9:08 AM

	Unknown Object (File)
	Sun, Feb 9, 9:08 AM

	Unknown Object (File)
	Sat, Jan 25, 7:24 AM

	Unknown Object (File)
	Sat, Jan 25, 7:24 AM

	Unknown Object (File)
	Sat, Jan 25, 7:24 AM

	Unknown Object (File)
	Sat, Jan 25, 7:24 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPb2ce0844b6ff: When a user clicks "Cancel" on an inline comment to leave the "Editing" state…

Summary

Ref T13513. Now that the "currently being edited" state of inlines is saved on the server side, clear the flag when the user clicks "Cancel" to leave the "editing" state on the client.

This also serves to delete empty comments.

Test Plan

Clicked a line number to create a new comment. Then:
- Clicked "Cancel". Reloaded page, saw no more comment.
- Typed text, saved. Reloaded page, saw non-editing draft. Clicked "Edit", reloaded page, saw editing draft. Clicked "Cancel", reloaded page, saw non-editing draft.
- Typed text, saved. Clicked "Edit", deleted text, saved. Reloaded page, saw no more comment.

Diff Detail

Repository

Branch

inline3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24274
Build 33437: Run Core Tests
Build 33436: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 29 2020, 6:34 PM

Harbormaster completed remote builds in B24273: Diff 50454.Apr 29 2020, 6:35 PM

epriestley requested review of this revision.Apr 29 2020, 6:35 PM

epriestley mentioned this in D21186: Make "editing" state persistent for inline comments.Apr 29 2020, 6:35 PM

Remove a redundant call to "setLoading(true)".

Harbormaster completed remote builds in B24274: Diff 50455.Apr 29 2020, 6:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:10 PM

Closed by commit rPb2ce0844b6ff: When a user clicks "Cancel" on an inline comment to leave the "Editing" state… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPb48a22bf50a3: Make "editing" state persistent for inline comments.

epriestley added a commit: rPb2ce0844b6ff: When a user clicks "Cancel" on an inline comment to leave the "Editing" state….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

infrastructure/

diff/

PhabricatorInlineCommentController.php

13 lines

webroot/

rsrc/

js/

application/

diff/

15 lines

Diff 50455

resources/celerity/map.php

Loading...

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...

webroot/rsrc/js/application/diff/DiffInline.js

Loading...