Page MenuHomePhabricator

When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change
ClosedPublic

Authored by epriestley on Apr 29 2020, 6:34 PM.
Tags
None
Referenced Files
F15409489: D21187.id50454.diff
Wed, Mar 19, 4:35 AM
F15333369: D21187.id50454.diff
Sat, Mar 8, 2:04 AM
F15292825: D21187.diff
Wed, Mar 5, 2:58 AM
Unknown Object (File)
Fri, Feb 21, 8:53 PM
Unknown Object (File)
Thu, Feb 20, 7:16 PM
Unknown Object (File)
Feb 17 2025, 2:28 AM
Unknown Object (File)
Feb 9 2025, 9:09 AM
Unknown Object (File)
Feb 9 2025, 9:09 AM
Subscribers
None

Details

Summary

Ref T13513. Now that the "currently being edited" state of inlines is saved on the server side, clear the flag when the user clicks "Cancel" to leave the "editing" state on the client.

This also serves to delete empty comments.

Test Plan
  • Clicked a line number to create a new comment. Then:
    • Clicked "Cancel". Reloaded page, saw no more comment.
    • Typed text, saved. Reloaded page, saw non-editing draft. Clicked "Edit", reloaded page, saw editing draft. Clicked "Cancel", reloaded page, saw non-editing draft.
    • Typed text, saved. Clicked "Edit", deleted text, saved. Reloaded page, saw no more comment.

Diff Detail

Repository
rP Phabricator
Branch
inline3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24273
Build 33435: Run Core Tests
Build 33434: arc lint + arc unit